[patch] wsgi must return strings

wsgiref+nevow example

patch for nevow.wsgi

What does it return if you don't have str()?

Could you turn the example into a set of unit tests?

I'm newbie in Nevow, so unit-tests are too hard for me.

Step-by-step reproduction is:

1. Write basic WSGI-app (taken from examples/wsgi/test-cgi.py

2. Put this app to any WSGI-server, for ex., from wsgiref

3. Open in browser, got traceback:

Traceback (most recent call last):
  File "/usr/local/egg/lib/python2.4/site-packages/wsgiref-0.1.2-py2.4.egg/wsgiref/handlers.py", line 93, in run
  File "/usr/local/egg/lib/python2.4/site-packages/wsgiref-0.1.2-py2.4.egg/wsgiref/handlers.py", line 133, in finish_response
  File "/usr/local/lib/python2.4/site-packages/nevow/wsgi.py", line 105, in application
    result = request.process()
  File "/usr/local/lib/python2.4/site-packages/nevow/wsgi.py", line 197, in process
    pageContext = self.site.getPageContextForRequestContext(requestContext)
  File "/usr/local/lib/python2.4/site-packages/nevow/wsgi.py", line 42, in getPageContextForRequestContext
    ctx.tag, path, pageContext)
  File "/usr/local/lib/python2.4/site-packages/nevow/wsgi.py", line 62, in handleSegment
    newres = inevow.IResource(newres, persist=True)
TypeError: __call__() got an unexpected keyword argument 'persist'

4. Remove presist=True in nevow.wsgi in line 62

5. Restart app, open it in browser, got traceback:

Traceback (most recent call last):
  File "/usr/local/egg/lib/python2.4/site-packages/wsgiref-0.1.2-py2.4.egg/wsgiref/handlers.py", line 93, in run
  File "/usr/local/egg/lib/python2.4/site-packages/wsgiref-0.1.2-py2.4.egg/wsgiref/handlers.py", line 133, in finish_response
  File "/usr/local/lib/python2.4/site-packages/nevow/wsgi.py", line 105, in application
    result = request.process()
  File "/usr/local/lib/python2.4/site-packages/nevow/wsgi.py", line 199, in process
    return self.gotPageContext(pageContext)
  File "/usr/local/lib/python2.4/site-packages/nevow/wsgi.py", line 215, in gotPageContext
    html = ''.join(list(html))
  File "/usr/local/lib/python2.4/site-packages/nevow/flat/ten.py", line 115, in iterflatten
    writer(tags.raw(''.join(straccum)))
  File "/usr/local/lib/python2.4/site-packages/nevow/wsgi.py", line 377, in write
    self._write(data)
  File "/usr/local/egg/lib/python2.4/site-packages/wsgiref-0.1.2-py2.4.egg/wsgiref/handlers.py", line 209, in write
AssertionError: write() argument must be string

6. Put str() in write(data), restart app, open it in browser, click to link "a", got traceback:

Traceback (most recent call last):
  File "/usr/local/egg/lib/python2.4/site-packages/wsgiref-0.1.2-py2.4.egg/wsgiref/handlers.py", line 93, in run
  File "/usr/local/egg/lib/python2.4/site-packages/wsgiref-0.1.2-py2.4.egg/wsgiref/handlers.py", line 133, in finish_response
  File "/usr/local/lib/python2.4/site-packages/nevow/wsgi.py", line 108, in application
    request.write('') # send headers now
  File "/usr/local/lib/python2.4/site-packages/nevow/wsgi.py", line 373, in write
    self._write = self.start_response(
  File "/usr/local/egg/lib/python2.4/site-packages/wsgiref-0.1.2-py2.4.egg/wsgiref/handlers.py", line 185, in start_response
AssertionError: Header values must be strings

7. Add header-sanitizing (sHeaders = [(str(k), str(v)) for k,v in self.outgoingHeaders]), restart app, play with it, all clean.

unittest for nevow.wsgi, which failes if bug #1743 not fixed

Unit-test is ready

Unit-test for ticket #1743, without wsgiref dependence

nevow.wsgi is deprecated and will be removed at some point. twisted.web should be used for wsgi instead (once twisted.web2.wsgi is ported).